-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup a few hidden imports in frame-support #1770
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kianenigma
added
R0-silent
Changes should not be mentioned in any release notes
T1-FRAME
This PR/Issue is related to core FRAME, the framework.
and removed
T1-FRAME
This PR/Issue is related to core FRAME, the framework.
labels
Oct 2, 2023
KiChjang
reviewed
Oct 4, 2023
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
bkchr
approved these changes
Oct 7, 2023
@@ -30,6 +30,7 @@ | |||
#![cfg_attr(not(feature = "std"), no_std)] | |||
|
|||
/// Export ourself as `frame_support` to make tests happy. | |||
#[doc(hidden)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be visible by default any way?
sam0x17
approved these changes
Oct 9, 2023
tdimitrov
pushed a commit
that referenced
this pull request
Oct 23, 2023
Just making a few hidden imports cleaner and hidden in docs. --------- Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
Just making a few hidden imports cleaner and hidden in docs. --------- Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Mar 26, 2024
Signed-off-by: acatangiu <adrian@parity.io>
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Mar 27, 2024
Signed-off-by: acatangiu <adrian@parity.io>
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
Signed-off-by: acatangiu <adrian@parity.io>
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
Signed-off-by: acatangiu <adrian@parity.io>
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
Signed-off-by: acatangiu <adrian@parity.io>
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
Signed-off-by: acatangiu <adrian@parity.io>
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
Signed-off-by: acatangiu <adrian@parity.io>
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
Signed-off-by: acatangiu <adrian@parity.io>
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
Signed-off-by: acatangiu <adrian@parity.io>
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
Signed-off-by: acatangiu <adrian@parity.io>
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
Signed-off-by: acatangiu <adrian@parity.io>
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
Signed-off-by: acatangiu <adrian@parity.io>
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
Signed-off-by: acatangiu <adrian@parity.io>
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 10, 2024
Signed-off-by: acatangiu <adrian@parity.io>
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 10, 2024
Signed-off-by: acatangiu <adrian@parity.io>
bkchr
pushed a commit
that referenced
this pull request
Apr 10, 2024
Signed-off-by: acatangiu <adrian@parity.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just making a few hidden imports cleaner and hidden in docs.